[PATCH] D58312: [WebAssembly] Generalize section ordering constraints

[Ben Smith via Phabricator via llvm-commits]

binji added a comment.

> I'm totally fine with specifying a mostly-linear ordering between sections, including between custom sections that are meaningful to the toolchain. But I think it also makes sense to allow for exceptions to that when it allows for simpler code, as is the case for the unspecified ordering between the producers section and relocation sections. This CL is about changing the mechanism to allow for this exception, not about changing the ordering of existing sections or changing our norm of specifying such orderings. Do you think we should disallow exceptions entirely?

I don't want to push back too hard on this. Since we're talking about tool conventions that are currently used by tools in the LLVM repos, it's probably OK. My point is just that if we don't have a total order, then it's likely that we'll eventually see modules that support all orderings, which will make it harder to reason about. My bias is toward being over-constrained at first, then loosening those constraints, so that's why I'd like to see something more strict here. But if it's especially burdensome to do so, then I think it's fine to go with a simpler solution, as long as it's sufficiently tested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58312/new/

https://reviews.llvm.org/D58312