[PATCH] D58407: [CMake] Include CheckSymbolExists in HandleLLVMOptions

[Petr Hosek via Phabricator via llvm-commits]

phosek created this revision.
phosek added reviewers: dsanders, smeenai, beanz.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.

In LLVM build, HandLLVMOptions relies on CheckSymbolExists being
included by config-ix, but HandleLLVMOptions is also being imported
from other parts of the build such as the runtimes build, libunwind,
libcxxabi, libcxx, and none of those include LLVM's config-ix which
is breaking the build. We should include CheckSymbolExists directly
in HandleLLVMOptions to make it self-contained rather than relying
on config-ix.


Repository:
  rL LLVM

https://reviews.llvm.org/D58407

Files:
  llvm/cmake/modules/HandleLLVMOptions.cmake


Index: llvm/cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- llvm/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -10,6 +10,7 @@
 include(HandleLLVMStdlib)
 include(CheckCCompilerFlag)
 include(CheckCXXCompilerFlag)
+include(CheckSymbolExists)
 
 if(CMAKE_LINKER MATCHES "lld-link\.exe" OR (WIN32 AND LLVM_USE_LINKER STREQUAL "lld") OR LLVM_ENABLE_LLD)
   set(LINKER_IS_LLD_LINK TRUE)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58407.187442.patch
Type: text/x-patch
Size: 486 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190219/821169cf/attachment.bin>