[PATCH] D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE

[Wei Mi via Phabricator via llvm-commits]

wmi marked an inline comment as done.
wmi added inline comments.


================
Comment at: lib/Analysis/InlineCost.cpp:282-285
+        // TODO: It is better to initialize ComputeFullInlineCost to true when
+        // Rpass=inline* is used to enable more precise report. However right
+        // now the check is inside of diagnose emission and we don't have a
+        // clean way to do the check here. It is something to be improved.
----------------
chandlerc wrote:
> Can't we query ORE as well as this bool in inline cost?
What we need is an API to check whether optimization remark report for some DEBUG_TYPE will be emitted. When doing the check in inline cost, we still need such API. The API doesn't depend on ORE, but will be implemented using things like OptimizationRemarkMissed::isEnabled. A difficulty here is that DEBUG_TYPE could be `inline-cost`, or `inline`. For both DEBUG_TYPE, we want the API to return true, but the check will be put in lib/Analysis/InlineCost.cpp and we only see DEBUG_TYPE to be inline-cost.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58399/new/

https://reviews.llvm.org/D58399