[PATCH] D58117: Workaround std::thread begin not copy-constructible

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 19 12:34:52 PST 2019


vitalybuka added inline comments.


================
Comment at: lib/fuzzer/FuzzerDefs.h:187
+
+      template< class U, class... Args >
+      void construct( U* p, Args&&... args ) {
----------------
please clang-format


================
Comment at: lib/fuzzer/FuzzerDefs.h:189
+      void construct( U* p, Args&&... args ) {
+        std::allocator<T>::construct(p, std::forward<Args>(args)...);
+      }
----------------
Could this be just:

```
      template<class... Args >
      void construct(Args&&... args ) {
        std::allocator<T>::construct(std::forward<Args>(args)...);
      }
```


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58117/new/

https://reviews.llvm.org/D58117





More information about the llvm-commits mailing list