[PATCH] D57909: [WebAssembly] Don't generate invalid modules when function signatures mismatch

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/wasm/Options.td:94
 
+def strict_signature_checking: F<"strict-signature-checking">,
+  HelpText<"Error on function signature mismatch">;
----------------
Sorry for being nitpicky, but since command line names cannot change once set, so bear with me...

There's no linker command line option that ends with `-checking`. Perhaps a most similar option is `-warn-mismatch` and `-no-warn-mismatch`, which is in the form of `-<verb>-...` and `-no-<verb>-`. Maybe we should follow that convention? I.e. `-check-signature`?

Does anyone have a suggestion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57909/new/

https://reviews.llvm.org/D57909