[PATCH] D58384: [ThinLTO] Fix test with reverse-iteration

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 19 09:29:59 PST 2019


dexonsmith added a comment.

In D58384#1402418 <https://reviews.llvm.org/D58384#1402418>, @evgeny777 wrote:

> Summary clusters, nodes and edges are retrieved from DenseMap with arbitrary order, which doesn't make result DOT file invalid.
>  Reverse iteration just exposes test issues.


Does that mean if we change the DenseMap hash, the test output will change?  That seems pretty unfortunate.  Can you sort the edges/nodes/etc. somehow to avoid this (either before or after dumping)?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58384/new/

https://reviews.llvm.org/D58384





More information about the llvm-commits mailing list