[PATCH] D58315: [WebAssembly] Add .shared directive for shared memory
    Wouter van Oortmerssen via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Feb 19 09:28:19 PST 2019
    
    
  
aardappel added inline comments.
================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:654
 
+    if (DirectiveID.getString() == ".shared") {
+      TOut.emitShared();
----------------
This applies to the most recent symbol? Seems many directives we have explicitly refer to the symbol they're changing, like .functype, .eventtype, .globaltype, so would it make sense for this to that too?
Or is there only ever one such flag and one such symbol, ever?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58315/new/
https://reviews.llvm.org/D58315
    
    
More information about the llvm-commits
mailing list