[PATCH] D57375: X86AsmParser AVX-512: Return error instead of hitting assert

[Phabricator via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL354356: X86AsmParser AVX-512: Return error instead of hitting assert (authored by ctopper, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D57375?vs=186213&id=187391#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57375/new/

https://reviews.llvm.org/D57375

Files:
  llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp
  llvm/trunk/test/MC/X86/avx512-err.s


Index: llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp
===================================================================
--- llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp
+++ llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp
@@ -1654,6 +1654,8 @@
   const AsmToken &Tok = Parser.getTok();
   // Eat "{" and mark the current place.
   const SMLoc consumedToken = consumeToken();
+  if (Tok.isNot(AsmToken::Identifier))
+    return ErrorOperand(Tok.getLoc(), "Expected an identifier after {");
   if (Tok.getIdentifier().startswith("r")){
     int rndMode = StringSwitch<int>(Tok.getIdentifier())
       .Case("rn", X86::STATIC_ROUNDING::TO_NEAREST_INT)
Index: llvm/trunk/test/MC/X86/avx512-err.s
===================================================================
--- llvm/trunk/test/MC/X86/avx512-err.s
+++ llvm/trunk/test/MC/X86/avx512-err.s
@@ -11,3 +11,6 @@
 
 // ERR: invalid operand for instruction
 cvtsd2sil  {rn-sae}, %xmm1, %eax
+
+// ERR: Expected an identifier after {
+cvtsd2sil  {{sae}, %xmm1, %eax


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57375.187391.patch
Type: text/x-patch
Size: 1029 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190219/282ce67c/attachment.bin>