[PATCH] D58266: [MC] Sort DWARF FDEs by the associated CIE before emitting them.

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Actually, I'm not sure if that is a bug in libstackunwind, but rather in LLVM.  I think that this is the behaviour that GCC has specifically for the `eh_frame` section.  This constraint is not part of the DWARF spec, but `eh_frame` even though it is similar to `debug_frame`, is not part of the DWARF spec, it just uses a similar encoding.  The change itself looks good, but, please wait for the discussion to complete before committing this.



================
Comment at: lib/MC/MCDwarf.cpp:1857
+      });
+  for (auto I = FrameArrayX.begin(), E = FrameArrayX.end(); I != E;) {
     const MCDwarfFrameInfo &Frame = *I;
----------------
While you are in the area, mind just switching this over to a range-based for loop?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58266/new/

https://reviews.llvm.org/D58266