[llvm] r354342 - GlobalISel: Verify g_insert
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 19 08:10:16 PST 2019
Author: arsenm
Date: Tue Feb 19 08:10:16 2019
New Revision: 354342
URL: http://llvm.org/viewvc/llvm-project?rev=354342&view=rev
Log:
GlobalISel: Verify g_insert
Added:
llvm/trunk/test/MachineVerifier/test_g_insert.mir
Modified:
llvm/trunk/lib/CodeGen/MachineVerifier.cpp
Modified: llvm/trunk/lib/CodeGen/MachineVerifier.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineVerifier.cpp?rev=354342&r1=354341&r2=354342&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/MachineVerifier.cpp (original)
+++ llvm/trunk/lib/CodeGen/MachineVerifier.cpp Tue Feb 19 08:10:16 2019
@@ -1288,6 +1288,30 @@ void MachineVerifier::verifyPreISelGener
report("extract reads past end of register", MI);
break;
}
+ case TargetOpcode::G_INSERT: {
+ const MachineOperand &SrcOp = MI->getOperand(2);
+ if (!SrcOp.isReg()) {
+ report("insert source must be a register", MI);
+ break;
+ }
+
+ const MachineOperand &OffsetOp = MI->getOperand(3);
+ if (!OffsetOp.isImm()) {
+ report("insert offset must be a constant", MI);
+ break;
+ }
+
+ unsigned DstSize = MRI->getType(MI->getOperand(0).getReg()).getSizeInBits();
+ unsigned SrcSize = MRI->getType(SrcOp.getReg()).getSizeInBits();
+
+ if (DstSize <= SrcSize)
+ report("inserted size must be smaller than total register", MI);
+
+ if (SrcSize + OffsetOp.getImm() > DstSize)
+ report("insert writes past end of register", MI);
+
+ break;
+ }
default:
break;
}
Added: llvm/trunk/test/MachineVerifier/test_g_insert.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MachineVerifier/test_g_insert.mir?rev=354342&view=auto
==============================================================================
--- llvm/trunk/test/MachineVerifier/test_g_insert.mir (added)
+++ llvm/trunk/test/MachineVerifier/test_g_insert.mir Tue Feb 19 08:10:16 2019
@@ -0,0 +1,44 @@
+# RUN: not llc -march=aarch64 -o /dev/null -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
+# REQUIRES: global-isel, aarch64-registered-target
+
+---
+name: test_insert
+legalized: true
+tracksRegLiveness: true
+liveins:
+body: |
+ bb.0:
+
+ ; CHECK: Bad machine code: Too few operands
+ %0:_(s32) = G_INSERT
+
+ ; CHECK: Bad machine code: Too few operands
+ ; CHECK: Bad machine code: generic instruction must use register operands
+ %1:_(s32) = G_INSERT 0
+
+ ; CHECK: Bad machine code: generic instruction must use register operands
+ ; CHECK: Bad machine code: generic instruction must use register operands
+ ; CHECK: Bad machine code: insert source must be a register
+ %2:_(s32) = G_INSERT 0, 0, 0
+
+ %3:_(s32) = G_IMPLICIT_DEF
+ %4:_(s1) = G_IMPLICIT_DEF
+
+ ; CHECK: Bad machine code: insert writes past end of register
+ %5:_(s32) = G_INSERT %3, %4, 32
+
+ ; CHECK: Bad machine code: insert offset must be a constant
+ %5:_(s32) = G_INSERT %3, %4, %3
+
+ ; CHECK: Bad machine code: insert offset must be a constant
+ %6:_(s32) = G_INSERT %3, %4, i32 4
+
+ %7:_(s64) = G_IMPLICIT_DEF
+
+ ; CHECK: Bad machine code: inserted size must be smaller than total register
+ %8:_(s32) = G_INSERT %3, %7, 0
+
+ ; CHECK: Bad machine code: inserted size must be smaller than total register
+ %9:_(s32) = G_INSERT %3, %3, 0
+
+...
More information about the llvm-commits
mailing list