[PATCH] D58379: [compiler-rt] Intercept the bcmp() function.

[James Y Knight via Phabricator via llvm-commits]

jyknight added inline comments.


================
Comment at: lib/asan/tests/asan_mem_test.cc:15
+#include <strings.h>  // for bcmp
+#elif defined(__NetBSD__)
+#include <string.h>  // for bcmp
----------------
MaskRay wrote:
> Maybe.. You can also enable it for OpenBSD `string.h` and FreeBSD `strings.h`
Both openbsd and netbsd appear to expose it from <strings.h> (plural) as the primary location too.

On both systems, <string.h> (singular) does a conditional #include of <strings.h>, so this probably works too, but seems better to consolidate around strings.h.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58379/new/

https://reviews.llvm.org/D58379