[PATCH] D58381: [mips] Put some MIPS-specific sections to separate segments

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/test/ELF/eh-frame-hdr-abs-fde.s:1
 # REQUIRES: mips
 # Check reading PC values of FDEs and writing lookup table in the .eh_frame_hdr
----------------
atanasyan wrote:
> grimar wrote:
> > I was wondering why this test case changed until saw it requires `mips`.
> > Should it just use x86 it seems?
> Do you like to convert this test for using x86 as a target architecture? If so, what is the reason?
Seems the functionality tested by this test is not MIPS specific, but generic and so is can be useful for all targets.
x86 is probably tested on more bots and used as a generic target in LLD (where all not target specific
features are usually tested).


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58381/new/

https://reviews.llvm.org/D58381