[PATCH] D58280: [yaml2obj][obj2yaml] - Support SHT_GNU_versym (.gnu.version) section.

Tue Feb 19 00:55:59 PST 2019

grimar marked 2 inline comments as done.
grimar added inline comments.

================
Comment at: test/tools/obj2yaml/versym-section.yaml:18
+# CHECK-NEXT:     Address:         0x0000000000200210
+# CHECK-NEXT:     Link:            .dynsym
+# CHECK-NEXT:     AddressAlign:    0x0000000000000002
----------------
jhenderson wrote:
> Should this have a link field? As far as I can see, the field is not specified in the specification.
Yes, it should:
sh_link here is a "The section header index of the associated symbol table. " 
according to generic specification about the special sections: 
(https://docs.oracle.com/cd/E19683-01/816-1386/chapter6-94076/index.html,
Table 7-15 ELF sh_link and sh_info Interpretation)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58280/new/

https://reviews.llvm.org/D58280