[PATCH] D58349: [Dominators] Fix and optimize edge insertion of depth-based search

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 3 inline comments as done.
MaskRay added inline comments.


================
Comment at: include/llvm/Support/GenericDomTreeConstruction.h:812
+        break;
+      TN = Stack.pop_back_val();
+    }
----------------
kuhar wrote:
> I'd prefer not to reassign(scalar) function arguments, mostly for readability and debugability.
I think this function actually harms readability. I deleted it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58349/new/

https://reviews.llvm.org/D58349