[PATCH] D52954: Annotate timeline in Instruments with passes and other timed regions.

Mon Feb 18 14:50:00 PST 2019

dsanders added a comment.

In D52954#1397449 <https://reviews.llvm.org/D52954#1397449>, @bogner wrote:

> Is there a more generic term for this than "signpost"? If so, it might be nice to use that to avoid confusion when/if other implementations show up. If not, that's fine.

ProfilerAnnotations would fit, it's possibly too generic though

================
Comment at: cmake/modules/HandleLLVMOptions.cmake:893
+
+option(LLVM_SUPPORT_XCODE_SIGNPOSTS "Enable support for Xcode signposts" OFF)
----------------
bogner wrote:
> Can we detect when this is available rather than make it an option?
We can test for os_signpost_interval_begin() and only offer it when it's available but I think it should be optional. The os_signpost family are very cheap (mostly due to the constant literal string requirements) but they do have a run-time cost.

================
Comment at: lib/Support/Signposts.cpp:98-99
+#if HAVE_ANY_SIGNPOST_IMPL
+  if (Impl == nullptr)
+    return false;
+  return Impl->isEnabled();
----------------
bogner wrote:
> Can Impl ever be null if HAVE_ANY_SIGNPOST_IMPL? I think we can remove these checks.
It shouldn't be possible. I'll remove them

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52954/new/

https://reviews.llvm.org/D52954