[PATCH] D58110: Support fiber API on macOS

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 18 11:13:34 PST 2019


kubamracek added a comment.

> watchOS/tvOS build is broken right now in trunk:
>  https://pastebin.com/Y3gsxtA7

The watchOS/tvOS parts of ASan require an internal SDK that's not publicly available to build. I guess that counts as "broken", but it's an expected state.

I think the tests are still going to fail on watchOS and tvOS, they need to be marked as UNSUPPORTED. At this point, I'm inclined to prefer to declare swapcontext ourselves (as swapcontext *is* available at runtime on watchOS/tvOS, it's just not allowed in the SDK) to avoid this much ifdef'ing and platform-specific workarounds. But if you strongly disagree, I'm okay with this approach also. (The tests still need updating.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58110/new/

https://reviews.llvm.org/D58110





More information about the llvm-commits mailing list