[PATCH] D58034: [IR/DIVar] Add flag for params that have unchanged values

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: docs/LangRef.rst:4714
+
+``DIFlags`` represents metadata attached to a DINode:
+
----------------
These flags encode various properties of DINodes.


================
Comment at: docs/LangRef.rst:4716
+
+- ``ArgumentNotModified`` flag marks a function argument which value
+is not modified trough the cource of a function. Having the info,
----------------
The ``ArgumentNotModified`` flag marks a function argument whose value...


================
Comment at: docs/LangRef.rst:4717
+- ``ArgumentNotModified`` flag marks a function argument which value
+is not modified trough the cource of a function. Having the info,
+a ``DW_OP_entry_value`` could be used for describing location information
----------------
`through the course` or `throughout`


================
Comment at: docs/LangRef.rst:4718
+is not modified trough the cource of a function. Having the info,
+a ``DW_OP_entry_value`` could be used for describing location information
+for the argument for places within its scope where
----------------
How about: `This flag is used to decide whether a DW_OP_entry_value can be used in a location description after the function prologue.`


================
Comment at: docs/LangRef.rst:4720
+for the argument for places within its scope where
+it has no location information at all. Frontend should check if variable
+meets the requirements and generate the flag within ``DILocalVariable``.
----------------
The language frontend is expected to compute this property for each DILocalVariable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58034/new/

https://reviews.llvm.org/D58034