[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

Mon Feb 18 09:03:08 PST 2019

craig.topper added inline comments.

================
Comment at: include/llvm/Support/X86TargetParser.def:93
 X86_CPU_SUBTYPE_COMPAT("znver1",         AMDFAM17H_ZNVER1,            "znver1")
+X86_CPU_SUBTYPE_COMPAT("znver2",         AMDFAM17H_ZNVER2,            "znver2")
 X86_CPU_SUBTYPE_COMPAT("ivybridge",      INTEL_COREI7_IVYBRIDGE,      "ivybridge")
----------------
This list must be kept in the same order as libgcc's implementation for __builtin_cpu_is. New entries can't be added in the middle. If libgcc doesn't support znver2 yet, then you should use X86_CPU_SUBTYPE instead of X86_CPU_SUBTYPE_COMPAT.

================
Comment at: lib/Target/X86/X86.td:1188
+                                         ZNFeatures.Value, [
+  FeatureCLZERO
+]>;
----------------
Why is CLZERO not in ZNFeatures? Looks common to both znver1 and znver2

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58343/new/

https://reviews.llvm.org/D58343