[PATCH] D58296: [llvm-objcopy] Make removeSectionReferences batched

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Don't know if you're planning on using the description as your commit message (I usually do), but there's a typo in it: abyssmal  -> abysmal.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/only-section-huge.test:1
+# Regression test that ensures reasonable performance for section removal, i.e.
+# selectively removing almost all sections on a large file takes a couple
----------------
How does this test show reasonable performance in a CI run? I don't see anything that checks that the runtime is sane.


================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.h:278
+  virtual Error
+  removeSectionReferences(const std::vector<const SectionBase *> &Sec);
   virtual Error removeSymbols(function_ref<bool(const Symbol &)> ToRemove);
----------------
`ArrayRef`?

Also Sec -> Sections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58296/new/

https://reviews.llvm.org/D58296