[PATCH] D58234: [llvm-objcopy] Add --add-symbol

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: tools/llvm-objcopy/CopyConfig.cpp:238
+  Value.split(Flags, ',');
+  getAsUnsignedInteger(Flags[0], 0, SI.Value);
+
----------------
The return value here is unchecked. What happens if Value is not a valid number?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58234/new/

https://reviews.llvm.org/D58234