[PATCH] D42870: Correct recognition of NetBSD images
Michał Górny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 18 06:20:39 PST 2019
mgorny marked an inline comment as done.
mgorny added inline comments.
================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1359
+ // p = patchlevel
+ const uint32_t version_major = version_info / 100000000;
+ const uint32_t version_minor = (version_info % 100000000) / 1000000;
----------------
Would it be crazy to rewrite this into `std::div` (i.e. to get both quotient and remainder in one call)?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D42870/new/
https://reviews.llvm.org/D42870
More information about the llvm-commits
mailing list