[PATCH] D57400: Add a .gitignore file to the root that ignores any files outside of the project directories.

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 18 05:00:20 PST 2019


sammccall added a comment.

In D57400#1400801 <https://reviews.llvm.org/D57400#1400801>, @labath wrote:

> FWIW, I am convinced by @kristina's arguments. Given that we store build trees in other stuff in the root folder (a practice which I am still trying to digest), I think we should have some safeguards to prevent them from accidentally being comitted. However, I don't feel like the right person to hit "approve" here.


+1, this is weird and I was skeptical, but am convinced (thanks for spelling out the arguments here @kristina!)

This really seems like a natural consequence of putting build directories alongside subprojects. If we're not willing to add this gitignore it seems like we should recommend an external build directory too to avoid confusion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57400/new/

https://reviews.llvm.org/D57400





More information about the llvm-commits mailing list