[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 16 15:27:43 PST 2019

tejohnson added a comment.
Herald added a subscriber: jdoerfert.

LGTM except for place noted below where I disagree with a change made earlier. Will let @davidxl chime in if he disagrees with me or has any other comments.

Comment at: lib/CodeGen/BackendUtil.cpp:967
+  if (CodeGenOpts.hasProfileCSIRInstr()) {
+    assert(!CodeGenOpts.hasProfileCSIRUse() &&
+           "Cannot have both CSProfileUse and CSProfileGen at the same time");
davidxl wrote:
> should emit error message instead.
I disagree with David's comment here. All the error checking should (and is) being done in Clang.cpp where the options are being processed. These and the places above for the old PM should just be asserts.



More information about the llvm-commits mailing list