[PATCH] D57800: [WebAssembly] LTO: Set POSIX thread model when linking with -shared-memoey

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: test/wasm/lto/atomics.ll:4
+; RUN: wasm-ld --shared-memory %t.o -o %t.shared.wasm -lto-O0
+; RUN: llvm-objdump -d %t.shared.wasm
+; RUN: llc %s -mattr=+atomics -o %t.threads.o
----------------
Can this check if the wasm file contains atomic instructions? There's no `CHECK` lines for that...


================
Comment at: test/wasm/lto/atomics.ll:5
+; RUN: llvm-objdump -d %t.shared.wasm
+; RUN: llc %s -mattr=+atomics -o %t.threads.o
+
----------------
Is this `llc` test relevant to this CL?


================
Comment at: test/wasm/lto/atomics.ll:11
 target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
 target triple = "wasm32-unknown-unknown-wasm"
 
----------------
No need for `-wasm`?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57800/new/

https://reviews.llvm.org/D57800