[PATCH] D57975: [ObjectYAML] Let dynamic entries use section names as values

Armando Montanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 15 16:18:11 PST 2019


amontanez updated this revision to Diff 187107.
amontanez retitled this revision from "[ObjectYAML][yaml2obj][ELF] Add support for writing dynamic entries" to "[ObjectYAML] Let dynamic entries use section names as values".
amontanez edited the summary of this revision.
amontanez added a comment.

Rebase, reduced patch contents to only include one feature addition. Rather than using a unified `Value` field, there's now `Value` and `String` fields. This was done because a unified `Value` field that could accept strings and numbers made it somewhat difficult for obj2yaml to output an appropriately formatted value. This is up for discussion, though, as I'm not sure what I've done is the best solution.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57975/new/

https://reviews.llvm.org/D57975

Files:
  llvm/include/llvm/ObjectYAML/ELFYAML.h
  llvm/lib/ObjectYAML/ELFYAML.cpp
  llvm/test/tools/yaml2obj/dynamic-entries.yaml
  llvm/test/tools/yaml2obj/dynamic-entry-invalid-val.yaml
  llvm/tools/obj2yaml/elf2yaml.cpp
  llvm/tools/yaml2obj/yaml2elf.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57975.187107.patch
Type: text/x-patch
Size: 12260 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190216/da29bb30/attachment.bin>


More information about the llvm-commits mailing list