[PATCH] D58312: [WebAssembly] Generalize section ordering constraints

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 15 16:15:56 PST 2019


sbc100 added a subscriber: binji.
sbc100 added a comment.

When we discussed this before @binji and others argued that a total ordering made more sense.



================
Comment at: llvm/test/MC/WebAssembly/relocs_and_producers.ll:1
+; RUN: llc %s -filetype=obj -o - | obj2yaml | yaml2obj | llvm-objdump -s /dev/stdin | FileCheck %s
+
----------------
Would it make sense to have the yaml checked in here directly and skip llc?  I think you can be explicit about the ordering of the sections in the input if the test is yaml.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58312/new/

https://reviews.llvm.org/D58312





More information about the llvm-commits mailing list