[PATCH] D58271: [ELF] --gdb-index: split off GdbSymbol::CuVector and add a separate CuVectors

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:2484
+createSymbols(
+    std::vector<std::vector<GdbIndexSection::NameAttrEntry>> NameAttrs,
+    const std::vector<GdbIndexSection::GdbChunk> &Chunks) {
----------------
Doesn't this make a copy of a vector? Is this vector always small?


================
Comment at: ELF/SyntheticSections.cpp:2543
+  const uint32_t CuVectorsSize = Off;
+  std::vector<uint32_t> CuVectors(CuVectorsSize, 0);
+
----------------
Perhaps I'm missing something, but why do you have to create both GdbIndex vector and CuVectors in this function? I wonder if you can split it up into two functions.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58271/new/

https://reviews.llvm.org/D58271