[PATCH] D58304: [WebAssembly] Warn but don't error on conflicting uses of prototype-less functions

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 15 15:23:38 PST 2019


sbc100 added a comment.

In D58304#1400010 <https://reviews.llvm.org/D58304#1400010>, @dschuff wrote:

> By "pick one at random" you mean we are rewriting one of the calls to drop or add parameters, right? And the one we pick is just the first one we happen to encounter?


Basically yes.  Although the rewriting is don't in FixFunctionBitcasts, this pass simply assigned a prototype where there was none.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58304/new/

https://reviews.llvm.org/D58304





More information about the llvm-commits mailing list