[PATCH] D58305: [lit] Allow setting parallelism groups to None

[Julian Lettner via Phabricator via llvm-commits]

yln created this revision.
Herald added subscribers: llvm-commits, delcypher.
Herald added a reviewer: serge-sans-paille.
Herald added a project: LLVM.

Check that we do not crash if a parallelism group is explicitly set to
None. Permits usage of the following pattern.

[lit.common.cfg]

  lit_config.parallelism_groups['my_group'] = None
  if <condition>:
    lit_config.parallelism_groups['my_group'] = 3

[project/lit.cfg]

  config.parallelism_group = 'my_group'


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D58305

Files:
  llvm/utils/lit/lit/TestingConfig.py
  llvm/utils/lit/lit/run.py
  llvm/utils/lit/tests/Inputs/parallelism-groups/lit.cfg
  llvm/utils/lit/tests/Inputs/parallelism-groups/test1.txt
  llvm/utils/lit/tests/Inputs/parallelism-groups/test2.txt
  llvm/utils/lit/tests/parallelism-groups.py


Index: llvm/utils/lit/tests/parallelism-groups.py
===================================================================
--- /dev/null
+++ llvm/utils/lit/tests/parallelism-groups.py
@@ -0,0 +1,21 @@
+# Check that we do not crash if a parallelism group is set to None. Permits
+# usage of the following pattern.
+#
+# [lit.common.cfg]
+#   lit_config.parallelism_groups['my_group'] = None
+#   if <condition>:
+#     lit_config.parallelism_groups['my_group'] = 3
+#
+# [project/lit.cfg]
+#   config.parallelism_group = 'my_group'
+#
+# Note: We need at least 2 tests to prevent lit from using "single process
+#       mode", which ignores parallelism groups.
+#
+
+# RUN: %{lit} -j2 %{inputs}/parallelism-groups | FileCheck %s
+
+# CHECK:     -- Testing: 2 tests, 2 threads --
+# CHECK-DAG: PASS: parallelism-groups :: test1.txt
+# CHECK-DAG: PASS: parallelism-groups :: test2.txt
+# CHECK:     Expected Passes    : 2
Index: llvm/utils/lit/tests/Inputs/parallelism-groups/test2.txt
===================================================================
--- /dev/null
+++ llvm/utils/lit/tests/Inputs/parallelism-groups/test2.txt
@@ -0,0 +1 @@
+# RUN: true
Index: llvm/utils/lit/tests/Inputs/parallelism-groups/test1.txt
===================================================================
--- /dev/null
+++ llvm/utils/lit/tests/Inputs/parallelism-groups/test1.txt
@@ -0,0 +1 @@
+# RUN: true
Index: llvm/utils/lit/tests/Inputs/parallelism-groups/lit.cfg
===================================================================
--- /dev/null
+++ llvm/utils/lit/tests/Inputs/parallelism-groups/lit.cfg
@@ -0,0 +1,11 @@
+import lit.formats
+config.name = 'parallelism-groups'
+config.suffixes = ['.txt']
+config.test_format = lit.formats.ShTest()
+config.test_source_root = None
+config.test_exec_root = None
+
+# Should not crash
+lit_config.parallelism_groups['my_group'] = None
+
+config.parallelism_group = 'my_group'
Index: llvm/utils/lit/lit/run.py
===================================================================
--- llvm/utils/lit/lit/run.py
+++ llvm/utils/lit/lit/run.py
@@ -17,6 +17,12 @@
         if self.failedCount == self.maxFailures:
             self.provider.cancel()
 
+# No-operation semaphore for supporting `None` for parallelism_groups.
+#   lit_config.parallelism_groups['my_group'] = None
+class NopSemaphore(object):
+    def acquire(self): pass
+    def release(self): pass
+
 class Run(object):
     """
     This class represents a concrete, configured testing run.
@@ -26,11 +32,10 @@
         self.lit_config = lit_config
         self.tests = tests
         # Set up semaphores to limit parallelism of certain classes of tests.
-        # For example, some ASan tests require lots of virtual memory and run
-        # faster with less parallelism on OS X.
-        self.parallelism_semaphores = \
-                {k: multiprocessing.BoundedSemaphore(v) for k, v in
-                 self.lit_config.parallelism_groups.items()}
+        self.parallelism_semaphores = {
+                k : NopSemaphore() if v is None else
+                    multiprocessing.BoundedSemaphore(v)
+                for k, v in lit_config.parallelism_groups.items()}
 
     def execute_test(self, test):
         return lit.worker._execute_test(test, self.lit_config)
Index: llvm/utils/lit/lit/TestingConfig.py
===================================================================
--- llvm/utils/lit/lit/TestingConfig.py
+++ llvm/utils/lit/lit/TestingConfig.py
@@ -106,7 +106,7 @@
                  environment, substitutions, unsupported,
                  test_exec_root, test_source_root, excludes,
                  available_features, pipefail, limit_to_features = [],
-                 is_early = False, parallelism_group = ""):
+                 is_early = False, parallelism_group = None):
         self.parent = parent
         self.name = str(name)
         self.suffixes = set(suffixes)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58305.187081.patch
Type: text/x-patch
Size: 3893 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190215/7caacc62/attachment.bin>