[PATCH] D58196: [lit][NFC] Cleanup lit worker process handling
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 15 13:05:51 PST 2019
rnk added a comment.
In D58196#1398802 <https://reviews.llvm.org/D58196#1398802>, @yln wrote:
> I just realized that we are still using "threads" for the display and command line options and different notions in the code: thread, jobs, workers. Since I am already at it, should I unify the terminology (in a separate patch)?
Sure. The way I see it "worker" is a more general term, so it's reasonable to use it in comments even if we use the `--numThreads` command line option.
Comment at: llvm/utils/lit/lit/worker.py:50-52
+ semaphore = parallelism_semaphores[pg]
This code is 2-space indented, but the rest of lit is mostly 4-space.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits