[PATCH] D58162: [hwasan] Runtime flags for malloc bisection.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: compiler-rt/lib/hwasan/CMakeLists.txt:28
   hwasan_mapping.h
+  hwasan_malloc_bisect.h
   hwasan_poisoning.h
----------------
nit: alphabetical order


================
Comment at: compiler-rt/test/hwasan/TestCases/malloc_bisect.c:5
+// RUN: %env_hwasan_opts=malloc_bisect_left=1000,malloc_bisect_right=999         %run %t 2>&1
+// RUN: %env_hwasan_opts=malloc_bisect_left=0,malloc_bisect_right=5000000000 not %run %t 2>&1 | \
+// RUN:     FileCheck %s --check-prefix=CRASH
----------------
Should this be 2^32 - 1 to prevent the test from being sensitive to the test environment?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58162/new/

https://reviews.llvm.org/D58162