[PATCH] D57834: [CodeExtractor] Only lift lifetime markers present in the extraction region

Sergei Kachkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 15 07:22:42 PST 2019


kachkov98 added a comment.

Just for note: it seems that skipping extracting lifetime.start when lifetime.end can't be lifted (in 2nd option) can again lead to miscompile as in https://reviews.llvm.org/D55967 (assume that markers for x and y in rhs are not lifted). It's safer to extract all lifetime.start markers referencing inputs to mark them all as simultaneously used, as in option (1).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57834/new/

https://reviews.llvm.org/D57834





More information about the llvm-commits mailing list