[PATCH] D58274: [MergeICmps] Make base ordering really deterministic.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: lib/Transforms/Scalar/MergeICmps.cpp:87
+    assert(Base && "invalid base");
+    // const auto Insertion = BaseToIndex.try_emplace(Base, Order);
+    const auto Insertion = BaseToIndex.emplace(Base, Order);
----------------
Remove.


================
Comment at: lib/Transforms/Scalar/MergeICmps.cpp:96
+  unsigned Order = 1;
+  // const DenseMap<const Value*, int> BaseToIndex;
+  std::unordered_map<const Value *, unsigned> BaseToIndex;
----------------
Remove


================
Comment at: lib/Transforms/Scalar/MergeICmps.cpp:106
+  if (!LoadI)
+    return BCEAtom();
+  LLVM_DEBUG(dbgs() << "load\n");
----------------
You may keep `{}` for consistency with `BCECmpBlock` below.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58274/new/

https://reviews.llvm.org/D58274