[PATCH] D58187: Teach DTU to recalculate DT/PDT automatically when EntryBB is changed

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 14 22:19:33 PST 2019


kuhar added inline comments.


================
Comment at: llvm/include/llvm/Analysis/DomTreeUpdater.h:257
 
+  /// If the entry block is changed, recalculate available trees.
+  /// Returns true if available trees are recalculated.
----------------
mkazantsev wrote:
> Should we do it for PDT when exit block is changed?
PDT's root never changes -- we use a virtual exit node to support multiple exits. DT should be handled in the same way IMO, but that's a lot of work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58187/new/

https://reviews.llvm.org/D58187





More information about the llvm-commits mailing list