[PATCH] D58028: Always compare C++ typeinfo (based on libstdc++ implementation).

Michael Spencer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 14 17:31:09 PST 2019


Bigcheese requested changes to this revision.
Bigcheese added a comment.
This revision now requires changes to proceed.

I do not believe this change is correct for MacOS or iOS.  The original bug does not reproduce on MacOS, and on arm64 iOS you always need to compare strings.  Could you preserve the existing behavior for those platforms?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58028/new/

https://reviews.llvm.org/D58028





More information about the llvm-commits mailing list