[PATCH] D58096: [LowerSwitch][AMDGPU] Do not handle impossible values

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

It seems weird to me that doing this somewhere else somehow ends up being more expensive, but this needs a comment somewhere explaining why it should be handled here



================
Comment at: lib/Transforms/Utils/LowerSwitch.cpp:145
+  LazyValueInfo *LVI = &getAnalysis<LazyValueInfoWrapperPass>().getLVI();
+  LVI->disableDT();
+
----------------
This is strange looking. I'm not sure what it really means to disable the dominator tree


================
Comment at: lib/Transforms/Utils/LowerSwitch.cpp:448-450
+  LLVM_DEBUG(dbgs() << "Clusterify finished. Total clusters: " << Cases.size()
+                    << ". Total non-default cases: " << NumSimpleCases << "\n");
+  LLVM_DEBUG(dbgs() << "Case clusters: " << Cases << "\n");
----------------
These can be merged into one LLVM_DEBUG (and single quotes around \n)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58096/new/

https://reviews.llvm.org/D58096