[PATCH] D57718: [PPC] Adjust the computed branch offset for the possible shorter distance

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 14 15:31:00 PST 2019


jsji added inline comments.


================
Comment at: test/CodeGen/PowerPC/branch_selector.ll:1
+; RUN: llc -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr8 -verify-machineinstrs < %s | FileCheck %s
+
----------------
Why we require -mcpu=pwr8 here? This should apply to all sub-target?


================
Comment at: test/CodeGen/PowerPC/branch_selector.ll:2
+; RUN: llc -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr8 -verify-machineinstrs < %s | FileCheck %s
+
+define i32 @relax_bcc(i1 %b) {
----------------
We should also test by changing default alignment here,
eg: `-align-all-functions=3`, which will make it pass without fix!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57718/new/

https://reviews.llvm.org/D57718





More information about the llvm-commits mailing list