[PATCH] D58246: [lld] Fix elf::unlinkAsync detached thread

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/Filesystem.cpp:77
+  std::unique_lock<std::mutex> L(M);
+  // Wait the thread to start. std::thread will touch function local variables
+  // installing atexing handlers. We want to make it happen before libc started
----------------
I don't know if I understand this comment correctly. Why don't you simply mention that there is a race condition in glibc 2.27 and earlier that crashes an entire process if the main thread calls exit(2) while other thread is starting up.

nit: please insert a blank line before a multi-line comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58246/new/

https://reviews.llvm.org/D58246