[PATCH] D58251: Extend "idempotent" atomicrmw optimizations to floating point

[JF Bastien via Phabricator via llvm-commits]

jfb added a subscriber: scanon.
jfb added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineAtomicRMW.cpp:33
+      return false;
+    };
+
----------------
@scanon for comment.


================
Comment at: lib/Transforms/InstCombine/InstCombineAtomicRMW.cpp:90
+    RMWI.setOperation(AtomicRMWInst::FAdd);
+    RMWI.setOperand(1, ConstantFP::getNegativeZero(RMWI.getType()));
+    return &RMWI;
----------------
I think you want to canonicalize to integer or with zero a well, and have casts. It's still just a load at the end of the day.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58251/new/

https://reviews.llvm.org/D58251