[PATCH] D58249: [lit] Set --single-process for single tests and --threads=1

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 14 13:14:38 PST 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good!

> `--single-process` is now essentially an alias for `-j1`. Should we remove it?

I think so. I'd commit this, and then send a quick follow-up patch to remove --single-process.



================
Comment at: llvm/utils/lit/lit/main.py:483
 
+    # Determine number of threads to use.
+    if opts.singleProcess:
----------------
Maybe say "workers" instead of "threads" since lit has been using multiprocessing everywhere for a long time now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58249/new/

https://reviews.llvm.org/D58249





More information about the llvm-commits mailing list