[PATCH] D58244: Canonicalize all "idempotent" atomicrmw ops
JF Bastien via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 14 12:21:38 PST 2019
jfb accepted this revision.
jfb added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Transforms/InstCombine/InstCombineAtomicRMW.cpp:65
+ return &RMWI;
> jfb wrote:
> > I don't think you want to canonicalize volatile accesses this way.
> Why? It's not changing the memory op implied. I can easy restrict, but why?
It's volatile, we just shouldn't touch it. The user asked for something silly, let's do something silly.
CHANGES SINCE LAST ACTION
More information about the llvm-commits