[PATCH] D58110: Support fiber API on macOS
Kuba (Brecka) Mracek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 14 10:57:49 PST 2019
kubamracek added a comment.
>> For the pragma diagnostic push/ignore stuff, we might be better off just redeclaring the function ourselves without including `ucontext.h`.
>
> For tsan_interceptors_mac.cc it can be done. For me such solution is more ugly than usage of #define and #pragma; but if you insist on it, I can do such change.
I also think it's more ugly, but I'm afraid the code won't build against watchOS and tvOS, where swapcontext is not just deprecated, but it's completely unavailable. @yln Can you please try to build this for watchOS/tvOS?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58110/new/
https://reviews.llvm.org/D58110
More information about the llvm-commits
mailing list