[llvm] r354039 - [SystemZ] Do not emit VEXTEND or VROUND nodes without vector support.

Jonas Paulsson via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 14 09:58:48 PST 2019


Author: jonpa
Date: Thu Feb 14 09:58:48 2019
New Revision: 354039

URL: http://llvm.org/viewvc/llvm-project?rev=354039&view=rev
Log:
[SystemZ] Do not emit VEXTEND or VROUND nodes without vector support.

Review: Ulrich Weigand
https://reviews.llvm.org/D58240

Added:
    llvm/trunk/test/CodeGen/SystemZ/fp-conv-18.mir
Modified:
    llvm/trunk/lib/Target/SystemZ/SystemZISelLowering.cpp

Modified: llvm/trunk/lib/Target/SystemZ/SystemZISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/SystemZ/SystemZISelLowering.cpp?rev=354039&r1=354038&r2=354039&view=diff
==============================================================================
--- llvm/trunk/lib/Target/SystemZ/SystemZISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/SystemZ/SystemZISelLowering.cpp Thu Feb 14 09:58:48 2019
@@ -5505,6 +5505,10 @@ SDValue SystemZTargetLowering::combineJO
 
 SDValue SystemZTargetLowering::combineFP_ROUND(
     SDNode *N, DAGCombinerInfo &DCI) const {
+
+  if (!Subtarget.hasVector())
+    return SDValue();
+
   // (fpround (extract_vector_elt X 0))
   // (fpround (extract_vector_elt X 1)) ->
   // (extract_vector_elt (VROUND X) 0)
@@ -5552,6 +5556,10 @@ SDValue SystemZTargetLowering::combineFP
 
 SDValue SystemZTargetLowering::combineFP_EXTEND(
     SDNode *N, DAGCombinerInfo &DCI) const {
+
+  if (!Subtarget.hasVector())
+    return SDValue();
+
   // (fpextend (extract_vector_elt X 0))
   // (fpextend (extract_vector_elt X 2)) ->
   // (extract_vector_elt (VEXTEND X) 0)

Added: llvm/trunk/test/CodeGen/SystemZ/fp-conv-18.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/SystemZ/fp-conv-18.mir?rev=354039&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/SystemZ/fp-conv-18.mir (added)
+++ llvm/trunk/test/CodeGen/SystemZ/fp-conv-18.mir Thu Feb 14 09:58:48 2019
@@ -0,0 +1,50 @@
+# RUN: llc -mtriple=s390x-linux-gnu -mcpu=z10 -start-before=codegenprepare %s \
+# RUN: -o - | FileCheck %s
+
+# Test that VEXTEND or VROUND nodes are not emitted without vector support.
+
+--- |
+  
+  @.str = external dso_local unnamed_addr constant [21 x i8], align 2
+  
+  define void @fun1() #0 {
+  bb:
+    %tmp = load <4 x float>, <4 x float>* undef, align 16
+    %tmp1 = extractelement <4 x float> %tmp, i32 0
+    %tmp2 = fpext float %tmp1 to double
+    %tmp3 = extractelement <4 x float> %tmp, i32 2
+    %tmp4 = fpext float %tmp3 to double
+    tail call void (i8*, ...) @printf(i8* getelementptr inbounds ([21 x i8], [21 x i8]* @.str, i64 0, i64 0), double %tmp2, double undef, double %tmp4, double undef)
+    ret void
+  }
+  
+  define void @fun2() #0 {
+  bb:
+    %tmp = load <2 x double>, <2 x double>* undef, align 16
+    %tmp1 = extractelement <2 x double> %tmp, i32 0
+    %tmp2 = fptrunc double %tmp1 to float
+    %tmp3 = extractelement <2 x double> %tmp, i32 1
+    %tmp4 = fptrunc double %tmp3 to float
+    tail call void (i8*, ...) @printf(i8* getelementptr inbounds ([21 x i8], [21 x i8]* @.str, i64 0, i64 0), float %tmp2, float undef, float %tmp4, float undef)
+    ret void
+  }
+  
+  declare dso_local void @printf(i8*, ...) #0
+  
+...
+
+# CHECK-LABEL: fun1:
+# CHECK: ldeb
+# CHECK-LABEL: fun2:
+# CHECK: ledbr
+
+---
+name:            fun1
+alignment:       4
+tracksRegLiveness: true
+...
+---
+name:            fun2
+alignment:       4
+tracksRegLiveness: true
+...




More information about the llvm-commits mailing list