[PATCH] D57561: [ThinLTO] Detect partially split modules during the thin link

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/LTO/LTO.cpp:828
+    return make_error<StringError>(
+        "inconsistent LTO Unit splitting with llvm.type.test "
+        "or llvm.type.checked.load (recompile with -fsplit-lto-unit)",
----------------
A user who sees this message isn't going to understand what `llvm.type.test` or `llvm.type.checked.load` means. Maybe omit this part of the error?


================
Comment at: lib/LTO/LTO.cpp:845
+        return make_error<StringError>(
+            "inconsistent LTO Unit splitting with llvm.type.test "
+            "or llvm.type.checked.load (recompile with -fsplit-lto-unit)",
----------------
Same here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57561/new/

https://reviews.llvm.org/D57561