[PATCH] D47127: [RISCV] Default enable RISCV linker relaxation

[Alex Bradbury via Phabricator via llvm-commits]

asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.
Herald added subscribers: jocewei, PkmX, rkruppe, jrtc27.
Herald added a project: LLVM.

I think the backend part of this has seen plenty of testing and it would be worth merging this change. Thanks!



================
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:370
+  bool Relax = true;
+  if (auto *A = Args.getLastArg(options::OPT_mrelax, options::OPT_mno_relax))
+    if (A->getOption().matches(options::OPT_mno_relax)) {
----------------
Personal preference that the LLVM coding style seems silent on, but I'll share anyway: I like omitting the braces for single-line blocks but find it a bit less readable in cases like this where the block's single statement spans multiple lines. I'd be tempted to add braces {}.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47127/new/

https://reviews.llvm.org/D47127