[PATCH] D58191: [DebugInfo] Make postra sinking of DBG_VALUEs safe in the presence of subregisters

[Jeremy Morse via Phabricator via llvm-commits]

jmorse marked 2 inline comments as done.
jmorse added inline comments.


================
Comment at: lib/CodeGen/MachineSink.cpp:1208
+    DbgValsToSink.insert(DbgValsToSink.begin(), DbgValsToSinkSet.begin(),
+                         DbgValsToSinkSet.end());
 
----------------
aprantl wrote:
> I think you may need to sort here to avoid nondeterministic output when iterating over a Set?
Good catch, I've added a sort to avoid relying on the sets order.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58191/new/

https://reviews.llvm.org/D58191