[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 20:00:00 PST 2019

thakis added a comment.

Thanks for starting the thread, Reid.

In D58157#1397260 <https://reviews.llvm.org/D58157#1397260>, @mehdi_amini wrote:

> Sorry, I don't have time to do archeology for you right now. But this is beside the point: your patch is changing a 2 years status quo, so my take on it is that it is *on you* to build the consensus to change this (maybe the consensus exists, I don't know, but this Phabricator diff alone seems quite light to demonstrate evidence of it).

The "2 years" isn't very relevant since the monorepo was some unofficial optional thing for most of those 2 years imho.

>> Else, I think this has seen more discussion than the change that is undoing. It also has the support of several folks very actively working on clang and clang-tools-extra.
> Again: I have no incentive to weigh one way or another with respect to what is the right way forward for clang-tools-extra, so I don't care what happens here.




More information about the llvm-commits mailing list