[PATCH] D58013: [compiler-rt] Build custom libcxx with libcxxabi

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

In D58013#1396761 <https://reviews.llvm.org/D58013#1396761>, @Hahnfeld wrote:

> @phosek Excellent idea. I tried to implement what you described and it seems to work great! The only minor disadvantage is that we now need to disable the tests if `COMPILER_RT_LIBCXXABI_PATH` is not found...


This is awesome, exactly what I had in mind, thank you so much for working on this!



================
Comment at: compiler-rt/cmake/Modules/CustomLibcxx/CMakeLists.txt:21
+set(LIBCXX_HERMETIC_STATIC_LIBRARY ON CACHE BOOL "")
+
+add_subdirectory(${COMPILER_RT_LIBCXX_PATH} ${CMAKE_CURRENT_BINARY_DIR}/cxx)
----------------
Should we also set `-DLIBCXX_ENABLE_EXCEPTIONS=OFF` to avoid the dependency on unwinder (e.g. libunwind or libgcc_s)? We already do this for libFuzzer but would it also make sense for MSan and TSan copies?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58013/new/

https://reviews.llvm.org/D58013