[PATCH] D58200: [RegAllocGreedy] Take last chance recoloring into account in evicting.
Mark Lacey via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 13 14:24:05 PST 2019
rudkx added inline comments.
Comment at: llvm/lib/CodeGen/RegAllocGreedy.cpp:2626
SmallVector<unsigned, 4> CurrentNewVRegs;
> IIRC ::insert returns a boolean that says whether or not it has been inserted.
> Thus, we can avoid the call to count and assert on the result of `::insert`.
Yes, I realize, but that would require assigning the result of `::insert`, asserting on it, and then doing something like `(void) inserted;` to avoid a warning, so this seemed cleaner and simpler to me.
Having said that, if you feel strongly about doing that rather than calling `::count` I'm more than happy to fix it up.
CHANGES SINCE LAST ACTION
More information about the llvm-commits