[PATCH] D57811: AMDGPU: Set ABI version to 1 for code object v3

Wed Feb 13 14:21:28 PST 2019

kzhuravl added a comment.

In D57811#1395643 <https://reviews.llvm.org/D57811#1395643>, @ruiu wrote:

> Just want to know a bit more about background of this change. Are you making an ABI-breaking change, so you are defining a new ABI version number for the AMDGPU target. Is this understanding correct? Is the AMDGPU target migrating to ABI version 2, or will version 1 and 2 co-exist in the future?

Yes, we are making an ABI-breaking change for amdgcn-amd-amdhsa, hence we are bumping ABI version to 1 for amdgcn-amd-amdhsa. Currently ABI versions 0 and 1 will co-exist in our backend. In the future, I am hoping we can drop ABI version 0 from our backend and only produce ABI version 1. I am not exactly sure where you got ABI version 2 from.

Our shared object loader and runtimes will keep supporting both variations of ABI versions.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57811/new/

https://reviews.llvm.org/D57811